Matthew Heath (Oct 02 2024 at 19:00): Matthew Heath (Oct 02 2024 at 19:00):Could someone please review this PR and approve the workflows?
I'm a little concerned the tests might not be running as intended.
Luke Boswell (Oct 02 2024 at 19:49):Kicked off CI
Luke Boswell (Oct 02 2024 at 22:23):I haven't seen that a cli test failure like that before... is this related to your change? (I don't see how it is)
---- cli_run::transitive_expects_verbose stdout ----
thread 'cli_run::transitive_expects_verbose' panicked at crates/cli/tests/cli_run.rs:314:17:
> expected output to end with:
Compiled in <ignored for test> ms.
Direct.roc:
0 failed and 2 passed in <ignored for test> ms.
Transitive.roc:
0 failed and 1 passed in <ignored for test> ms.
> but instead got:
Compiled in <ignored for test> ms.
Transitive.roc:
0 failed and 1 passed in <ignored for test> ms.
Direct.roc:
0 failed and 2 passed in <ignored for test> ms.
@Luke Boswell it's actually fixed by your --prebuilt-platform change
Luke Boswell (Oct 03 2024 at 00:08):Woah, that's nice.
Sam Mohr (Oct 03 2024 at 00:08):Looking for the specific change
Sam Mohr (Oct 03 2024 at 00:08):Anyway, this specific issue has been present for at least a few months
Sam Mohr (Oct 03 2024 at 00:12): Sam Mohr (Oct 03 2024 at 00:12):Here's the fix
Sam Mohr (Oct 03 2024 at 00:12):We could pull it out into a separate PR now, I just didn't mention it because I figured things would merge soon haha
Luke Boswell (Oct 03 2024 at 00:22):I'd really like to merge that PR -- it's got a lot of other fixes in there too
Luke Boswell (Oct 03 2024 at 00:23):Specifically this one https://github.com/roc-lang/roc/pull/6859
Luke Boswell (Oct 03 2024 at 00:23):I haven't kicked it in a while, because @Anton has a bunch of additions he hasn't pushed yet
Matthew Heath (Oct 03 2024 at 21:39):Luke Boswell said:
I haven't seen that a cli test failure like that before... is this related to your change? (I don't see how it is)
---- cli_run::transitive_expects_verbose stdout ---- thread 'cli_run::transitive_expects_verbose' panicked at crates/cli/tests/cli_run.rs:314:17: > expected output to end with: Compiled in <ignored for test> ms. Direct.roc: 0 failed and 2 passed in <ignored for test> ms. Transitive.roc: 0 failed and 1 passed in <ignored for test> ms. > but instead got: Compiled in <ignored for test> ms. Transitive.roc: 0 failed and 1 passed in <ignored for test> ms. Direct.roc: 0 failed and 2 passed in <ignored for test> ms.
I'm glad it sounds not related.
Sam Mohr (Oct 03 2024 at 23:57):It's not related
Sam Mohr (Oct 03 2024 at 23:57):Let me try to get the test passing tonight, we should be able to get your PR through ASAP!
Sam Mohr (Oct 03 2024 at 23:57):Thanks for your patience
Anton (Oct 04 2024 at 09:13):I'd really like to merge that PR -- it's got a lot of other fixes in there too
I'm still trying to fix this bug, I'll be working on it today.
Sam Mohr (Oct 05 2024 at 20:05):@Matthew Heath apologies for the delay, I'm out of state until tomorrow night for a singing competition.
Sam Mohr (Oct 05 2024 at 20:05):I'll message you when I review this
Matthew Heath (Oct 05 2024 at 22:21):@Sam Mohr No worries. I hope the competition goes well :)
Matthew Heath (Nov 03 2024 at 21:09):@Sam Mohr Do you have any updates on this?
Last updated: Jul 06 2025 at 12:14 UTC