signing commits · contributing · Zulip Chat Archive

I'm sorry, but I can't seem to make it work. I hid my personal email, created a gpg key for it, added it to github, created an ssh key for that email, added that to github, told github to use that ssh key, signed the commit with gpg and it still shows up as unverified. I can't seem to find a way to verify it. :sob:

Anton (Mar 20 2023 at 08:52):

Do not despair, help is here :)
I have my email address hidden as well (17049058+Anton-4@users.noreply.github.com), I believe you need to create the key using the @users.noreply.github.com address, did you do that?

Anton (Mar 20 2023 at 09:25):

@itmuckel can you suggest how we can improve contribution tips to make setting this up easier?

dank (Mar 20 2023 at 13:05):

this is related but unrelated; i had a lot of pain getting pinentry to work properly (it is required for gnupg)

i believe it was a mismatch of the pinentry interface
might be helpful to folks in the future on nixos specifically seeing this thread (and in general-), to set the pinentry gui lib properly (there's also a tui but it didn't work at all for me, display was messed up and non-desired characters were inserted whenever you typed, which caused you to enter wrong password without noticing 3 times and getting blocked, horrible interface)

  programs.gnupg.agent = {
    enable = true;
    pinentryFlavor = "qt";
    enableSSHSupport = true;
  };

[other pinentryFlavors didnt work for me on kde with konsole as terminal emulator]

Anton (Mar 20 2023 at 13:16):

Thanks for mentioning it @dank, I have it set up in the same way, I'll add that to the contribution tips.

itmuckel (Mar 24 2023 at 20:54):

My problem, or at least I think the problem was gone, when I resolved this: I only changed my email address, but not my user name so my user name differed from my github user name. GitHub was absolutely no help here, because it showed me the correct hash for a key that was already added to my GitHub, so it was more trial and error. :nerd:

Anton (Mar 25 2023 at 09:07):

With user name, do you mean the name you have set locally in ~/.config/git/config?

itmuckel (Mar 25 2023 at 09:48):

No, the author of the commit that comes before the email
git commit --amend --author="itmuckel <18561536+itmuckel@users.noreply.github.com>" --no-edit
Here I had my real name in front of the email address and my theory is that it confused github :man_shrugging:

Anton (Mar 25 2023 at 09:53):

I see, I do think if you don't manually set the author flag it uses the name and email form .config/git/config

Stream: contributing

Topic: signing commits

itmuckel (Mar 19 2023 at 08:42):