Tero Laxström (Jun 10 2023 at 09:06): Tero Laxström (Jun 10 2023 at 09:06):I've been looking at https://github.com/roc-lang/roc/issues/3797 and it looks quite straight forward. Would it be ok in mod.rs to just move current build_num_mul code to new build_num_mul_wrap and then call that from the old function and add a comment about panic like on build_num_sub? And of course also add/change everywhere like it should be?
Tero Laxström (Jun 10 2023 at 12:53):Made a draft PR: https://github.com/roc-lang/roc/pull/5538
Would it be better to just copy the num_mul for mod.rs? Or am I doing something completely wrong :sweat_smile:
Folkert de Vries (Jun 10 2023 at 14:24):looks fine to me
Tero Laxström (Jun 12 2023 at 09:01):Would something else be needed to close the ticket?
Anton (Jun 14 2023 at 11:50):I don't think so, I've closed the issue, thanks @Tero Laxström :)
Last updated: Jul 06 2025 at 12:14 UTC