Stream: contributing

Topic: TUI platform doesn't call view on initial model

view this post on Zulip Nick Gravgaard (Oct 24 2022 at 07:05):

I'm porting over a little text game from Elm to Roc, and noticed the TUI platform doesn't display the initial model. I figured this must be a bug as otherwise a program can't display a prompt or ask a question before taking input from the user. I raised an issue and fixed it in a PR :smile:

view this post on Zulip Anton (Oct 24 2022 at 07:16):

Thanks @Nick Gravgaard, I've requested Folkert for review because he wrote the original file.

view this post on Zulip Nick Gravgaard (Oct 24 2022 at 08:24):

Thanks @Anton, @Folkert de Vries. All the checks passed in GitHub but now it's saying "Merging is blocked - The base branch requires all commits to be signed." Is that something I need to do?

view this post on Zulip Folkert de Vries (Oct 24 2022 at 08:25):

yes, @Anton do we have a link somewhere to quickly fix this problem?

view this post on Zulip Folkert de Vries (Oct 24 2022 at 08:27):

https://github.com/roc-lang/roc/blob/main/CONTRIBUTING.md#contribution-tips has instructions for setting up commit signing

view this post on Zulip Folkert de Vries (Oct 24 2022 at 08:27):

but what that does not show is how to fix commits of an existing PR. I'd guess that an git commit --amend on that commit and then force pushing does it? but not sure

view this post on Zulip Nick Gravgaard (Oct 24 2022 at 08:51):

I did git commit --amend --signoff which seems to have worked. I think someone needs to re-review the PR. @Folkert de Vries can you have a look again?

view this post on Zulip Folkert de Vries (Oct 24 2022 at 08:52):

yes, that looks good

view this post on Zulip Nick Gravgaard (Oct 24 2022 at 09:00):

@Folkert de Vries On the PR page, GitHub says I dismissed folkertdev’s stale review. That must have happened when I force pushed over the old unsigned commit with the signed commit. I think you need to approve it again :pray:

view this post on Zulip Folkert de Vries (Oct 24 2022 at 09:05):

done, just waiting for CI now

view this post on Zulip Anton (Oct 24 2022 at 10:07):

I'll make an issue to add "How to sign unsigned commits" to CONTRIBUTING.md

view this post on Zulip Nick Gravgaard (Oct 26 2022 at 10:42):

Hey @Folkert de Vries, I missed an obvious refactor in my last PR. Could you have a look at this new one? https://github.com/roc-lang/roc/pull/4405

Last updated: Jul 06 2025 at 12:14 UTC