Stream: contributing

Topic: Roc formatter replaces ### by # ##


view this post on Zulip Michael Pfeifer (Jan 21 2024 at 16:56):

Some time ago, I opened pull request #6329 that was supposed to resolve issue #6328 opened in the context of the current discussion. Since the Roc formatter replaces ### by # ##, I would like to discuss how to proceed.

Where is the right place for such discussions? Zulip? The GitHub Issue? One linking to the other?

view this post on Zulip Luke Boswell (Jan 21 2024 at 17:33):

Zulip is probably the best for a discussion. Does the formatter need to be updated? I think the issue might be that ### looks like a comment with a heading.

view this post on Zulip Luke Boswell (Jan 21 2024 at 17:35):

We probably want to use just one hash, like # start snippet hello actually.

view this post on Zulip Luke Boswell (Jan 21 2024 at 17:35):

Thank you for putting the time into resolving this issue :grinning:

view this post on Zulip Notification Bot (Jan 21 2024 at 18:04):

4 messages were moved here from #beginners > Tutorial: self-referential record destructuring by Brendan Hansknecht.

view this post on Zulip Brendan Hansknecht (Jan 21 2024 at 18:05):

I think @Anton should be back from vacation soon. Maybe even tomorrow.

He probably is best to shed some light on this.

view this post on Zulip Brendan Hansknecht (Jan 21 2024 at 18:06):

Personally, I think it should be fine to allow any number of ###### in a row if someone wants to use them.

view this post on Zulip Brendan Hansknecht (Jan 21 2024 at 18:06):

So probably just a small formatter change?

view this post on Zulip Kiryl Dziamura (Jan 21 2024 at 19:02):

Just wondering how comment/uncomment logic should work in editors for cases like this. Feels like it should be a no-op for comments with multiple hashes :thinking:

view this post on Zulip Brendan Hansknecht (Jan 21 2024 at 19:14):

Should be able to work the same as it works for python

view this post on Zulip Brendan Hansknecht (Jan 21 2024 at 19:15):

So I wouldnt be too worried


Last updated: Jul 06 2025 at 12:14 UTC