Philippe (Mar 03 2022 at 20:16): Philippe (Mar 03 2022 at 20:16):A bit of a silly question
I have finished https://github.com/rtfeldman/roc/pull/2629
What is the process to ask for reviews?
Folkert de Vries (Mar 03 2022 at 20:47):in practice, once it's green on CI someone will get to it in ~ 48hrs
Hashi364 (Jun 03 2022 at 23:34):Hi, I'm new there, I think I found a typo in TUTORIAL.md. Lines 325 and 326 addWithStringfy are only used there I think they should be addAndStringfy. I'm kinda new to open source stuff, so I made a PR without reading the CONTRIBUTING.md and it was directly in the trunk branch (sorry) (this one: https://github.com/rtfeldman/roc/pull/3177).
If there is some think wrong, tell me and I'll try to fix.
Folkert de Vries (Jun 04 2022 at 07:23):I think if you merge in trunk that CI error will go away
Chris Duncan (Oct 15 2022 at 23:52):I just submitted a PR for adding a title for documentation pages. I wanted to do a narrower change, but I was getting some Rust memory management errors I didn't fully understand. Can someone review this PR and let me know what I can improve on it?
Folkert de Vries (Oct 15 2022 at 23:57):I think you need to run cargo fmt --all on it, some whitespace seems to be missing
Chris Duncan (Oct 16 2022 at 00:44):Done! :+1:
Chris Duncan (Oct 16 2022 at 00:45):I added Format on Save because I know I'll forget :sweat_smile:
Kiryl Dziamura (May 21 2024 at 23:06):created a couple of prs (please also assign the related issues to me):
Ignore comments in repl - need to add tests, but first, I'd like to check if my changes are correct
Better message for bad ident name in repl - very simple one liner
Last updated: Jul 06 2025 at 12:14 UTC