Stream: contributing

Topic: Num.toI64 on U32 returns negative number

Wizard ish (Nov 25 2024 at 22:01):

Sorry, I'm kinda new to open source projects, so sorry if my work is a bit scuffed.
Is anyone else working on this?

Luke Boswell (Nov 25 2024 at 22:17):

I don't think anyone else is

Luke Boswell (Nov 25 2024 at 22:18):

I haven't seen anything related to this in a while

Luke Boswell (Nov 25 2024 at 22:19):

Your talking about this issue right? https://github.com/roc-lang/roc/issues/7184

Wizard ish (Nov 25 2024 at 22:19):

yes

Sam Mohr (Nov 25 2024 at 22:27):

@Wizard ish I'll assign it to you if you're down to pick it up! We'd love to take your contribution

Wizard ish (Nov 25 2024 at 22:27):

Yes :)

Luke Boswell (Nov 25 2024 at 22:28):

Yeah, I just don't know your GH handle -- I was thinking the same as Sam

Sam Mohr (Nov 25 2024 at 22:28):

What's your username?

Wizard ish (Nov 25 2024 at 22:28):

https://github.com/wizard7377

Luke Boswell (Nov 25 2024 at 22:29):

Hmm... I can't seem to add you using the web UI maybe you need to make a comment or something, seems strange

Sam Mohr (Nov 25 2024 at 22:30):

We'll figure it out :smile:

Luke Boswell (Nov 25 2024 at 22:30):

Got it

Luke Boswell (Nov 25 2024 at 22:31):

Must have needed you to make a comment first :smiley:

Wizard ish (Nov 26 2024 at 22:38):

It is done (if a little overenginered) :)

Luke Boswell (Nov 26 2024 at 23:22):

@Wizard ish -- I kicked off CI for this.

What do you think about adding some tests? I think they would live in here crates/compiler/test_gen/src/gen_num.rs but not 100%.

Wizard ish (Nov 26 2024 at 23:23):

yeah, i actually was going to but realized that I didnt know where to put it and didnt know if i should

Wizard ish (Nov 27 2024 at 19:20):

@Luke Boswell Alright tests are added

Wizard ish (Nov 28 2024 at 00:24):

Shoot they need to be signed, ill do it tmrw

Wizard ish (Nov 28 2024 at 13:38):

well i managed to sevely screw that up

Anton (Nov 28 2024 at 14:43):

No problem, we can force the merge even though there is one unsigned commit

Anton (Nov 28 2024 at 14:44):

well i managed to sevely screw that up

Oh, are the tests gone?

Wizard ish (Nov 28 2024 at 14:58):

oh shoot

Wizard ish (Nov 28 2024 at 14:58):

let me re-add them

Wizard ish (Nov 28 2024 at 15:12):

Ok re-added them, and unless yall want me to i think it's best if i dont try and sign the pushed commits

Last updated: Jul 06 2025 at 12:14 UTC