mdznta (Dec 02 2023 at 23:33): mdznta (Dec 02 2023 at 23:33):Hey all! I grabbed an issue (#6109) to start contributing to roc and have a few questions/want to run my idea of changes past some people to make sure I am making good changes before requesting reviews, etc. Is this a good forum to just ask openly and get some feedback?
Richard Feldman (Dec 02 2023 at 23:39):absolutely, ask away! :smiley:
mdznta (Dec 03 2023 at 04:07):So I am somewhat new to the project but have looked around a little bit so forgive any noob questions :). My initial thought was to add a check for a 404 in packaging/src/https, add to the Problem enum, and then add some blurb about file not being found in reporting/src/error/report.rs. Does that seem reasonable?
Brian Carroll (Dec 03 2023 at 07:14):Yeah that sounds about right
mdznta (Dec 03 2023 at 14:42):Thanks both! :smiley:
mdznta (Dec 04 2023 at 01:08):I'm not quite there yet but once we have a draft PR open and we think it looks good, do we just ask in here to get a review or do folks kind of sort through them on their own?
Ayaz Hafiz (Dec 04 2023 at 01:09):Asking for a review here is the most helpful
mdznta (Dec 06 2023 at 00:40):Would #6169 be a good first issue to get into the dev backend a bit? I haven't had any experience yet but am keen to take a look.
Brendan Hansknecht (Dec 06 2023 at 01:07):It would probably be ok. I think everything is wired up for roc_panic, so it should be reasonable
Richard Feldman (Dec 06 2023 at 11:52):feel free to ask any questions about it! :smiley:
mdznta (Dec 07 2023 at 21:55):I'll limit my spam to this thread in the short term but I picked up #6164 and it seems that it is something that may need some outside input. So when it comes to the current List.split, is there any interest in changing that to something else like List.splitAt like in the issue? In order to most closely match what Str.split is doing, List.split should also take in an element to split on then? Thanks in advance :smile:
LoipesMas (Dec 07 2023 at 22:09):If I were to name those functions, I would name them splitAt and splitBy, to avoid confusion. splitAt would take an index and return {before, after} and splitBy would take an element value (a for List a, Str for Str) and split by that. That would be a breaking change, but it's better to make them early, right?
Brendan Hansknecht (Dec 07 2023 at 22:37):Yeah, I agree with that. Clarity of those two names if much better
Richard Feldman (Dec 08 2023 at 02:18):can we start an #ideas about that? Some people might have input on that who don't follow the #contributing channel :big_smile:
Last updated: Jul 06 2025 at 12:14 UTC