Stream: contributing

Topic: Latest PR (#8487 str-to-utf8) fails the tests

Matthieu Pizenberg (Nov 28 2025 at 09:40):

The latest merged PR makes the tests fail on my machine (osx M3, zig 0.15.2).
https://github.com/roc-lang/roc/pull/8487

Build Summary: 50/59 steps succeeded; 4 failed; 1039/1055 tests passed; 16 failed
test transitive failure
└─ tests_summary transitive failure
   ├─ run test eval transitive failure
   │  └─ compile test eval Debug native 1 errors
   ├─ run test repl transitive failure
   │  └─ compile test repl Debug native 1 errors
   ├─ run test snapshot_tool_test transitive failure
   │  └─ compile test snapshot_tool_test Debug native 1 errors
   └─ run test fx_platform_test 0/16 passed, 16 failed

Matthieu Pizenberg (Nov 28 2025 at 09:44):

This is the error I see most in the error message, which is huge.

src/eval/interpreter.zig:9615:94: error: missing struct field: saved_rigid_subst
                            try work_stack.push(.{ .apply_continuation = .{ .call_cleanup = .{
                                                                                            ~^

Anton (Nov 28 2025 at 10:02):

Thanks for reporting @Matthieu Pizenberg! I was able to reproduce and will investigate.

Anton (Nov 28 2025 at 10:13):

I suspect this error snuck in because we don't use a merge queue. I don't think we should use one though to avoid a large increase in our power usage even though github CI is free. It just seems wasteful given how rarely it creates problems.

Anton (Nov 28 2025 at 11:01):

PR#8489 should fix it (not merged yet).

Anton (Nov 28 2025 at 11:30):

Merged :)

Richard Feldman (Nov 28 2025 at 17:23):

yeah we used to have a merge queue and it was more annoying than helpful, so we ended up accepting that occasionally we will land two PRs that interact to break main, and that's the less bad option for now :smile:

Isaac Van Doren (Nov 28 2025 at 18:21):

:100:

Isaac Van Doren (Nov 28 2025 at 18:21):

Merge queues are so annoying

Brendan Hansknecht (Nov 28 2025 at 20:47):

When they work well, at scale, they are awesome.

But most implementations I have seen, especially ones used with Github, are much more pain than good.

Brendan Hansknecht (Nov 28 2025 at 20:54):

In work environments, I am definitely a fan of one commit per PR with the ability to create a small tree of PRs, but I have not seen that implemented well in open source.

Brendan Hansknecht (Nov 28 2025 at 20:54):

And that workflow works best with being able to merge a stack at once or automatically with a queue.

Last updated: Dec 21 2025 at 12:15 UTC