Fabian Schmalzried (Mar 16 2024 at 14:59): Fabian Schmalzried (Mar 16 2024 at 14:59):I created a draft PR for the discussion here:
https://github.com/roc-lang/roc/pull/6591
First time adding something, so I need some help with the llvm lowlevel
Brendan Hansknecht (Mar 16 2024 at 18:08):Skimmed it on my phone, base looks good. Zig may have some helpers related to floats to do it in one generic method, but that isn't too important. If no one else gets to it before me, I'll review/double check issues tonight.
Fabian Schmalzried (Mar 16 2024 at 18:10):Thanks, I also just thought about just moving more to roc and just have an internal f32 to u32 function in zig. Would that make sense?
Brendan Hansknecht (Mar 16 2024 at 18:59):I would just leave it in zig.
Brendan Hansknecht (Mar 16 2024 at 18:59):But doesn't particularly matter either way
Fabian Schmalzried (Mar 22 2024 at 16:18):I don't think I can figure LLVM out on my own.
Anton (Mar 22 2024 at 16:23):What part exactly do you need help with?
Fabian Schmalzried (Mar 22 2024 at 16:29):What to write in crates/compiler/gen_llvm/src/llvm/lowlevel.rs
Anton (Mar 22 2024 at 16:52):I can take a look tomorrow if no one else is available
Brendan Hansknecht (Mar 25 2024 at 04:48):Does this still need more help? I can probably look at it soon if so.
Luke Boswell (Mar 25 2024 at 05:09):Yes I think it does.
Anton (Mar 25 2024 at 08:59):@Brendan Hansknecht https://roc.zulipchat.com/#narrow/stream/395097-compiler-development/topic/gen.20llvm.20NumF32ToParts/near/429104409
Fabian Schmalzried (Apr 01 2024 at 19:11):https://github.com/roc-lang/roc/pull/6591 Should work now, can someone start the workflows?
Last updated: Jul 05 2025 at 12:14 UTC