Sam Mohr (Jan 09 2025 at 01:18): Sam Mohr (Jan 09 2025 at 01:18):When updating the tests for the snake_case change, it was really easy to miss a lot of syntax issues because everything was in a string. We might consider moving as many tests into snapshots as possible at some point, but for now, we can still make catching these issues easy by giving warnings for old syntax, including:
\args -> syntax once we move to |args| syntaxAnyone disagree? Otherwise I can do this, probably no issue needed.
Luke Boswell (Jan 09 2025 at 01:22):"my string ${interpolation}" too
Sam Mohr (Jan 09 2025 at 01:25):I keep forgetting that one, good catch
Luke Boswell (Jan 09 2025 at 01:28):The other one mentioned in the Richard's draft blog about functional PI is the ??
Luke Boswell (Jan 09 2025 at 01:29):I'm not sure we're tracking any Issues for that
Sam Mohr (Jan 09 2025 at 01:31):They're mentioned here: https://github.com/roc-lang/roc/issues/7086
Luke Boswell (Jan 09 2025 at 01:32):Nvm.. I just realised it's already implemented. :sweat_smile:
main! = \_args ->
value = Env.var!("NAME") ?? "LUKE"
Stdout.line!("Hello, $(value)!")
Anthony is a Bull in an Unimplemented Syntax Shop
Anthony Bullard (Jan 09 2025 at 02:58):What did I do now?
Anthony Bullard (Jan 09 2025 at 02:59):Oh ??
Anthony Bullard (Jan 09 2025 at 02:59):Yeah I did that
Anthony Bullard (Jan 09 2025 at 03:00):I’m dragging Roc into the future
Anthony Bullard (Jan 09 2025 at 03:00):Luckily not kicking and screaming. That my four year olds job
Sam Mohr (Jan 09 2025 at 21:37):Can tags have single underscores in them?
Sam Mohr (Jan 09 2025 at 21:38):Normal tags are PascalCase
Sam Mohr (Jan 09 2025 at 21:38):But I've been seeing some SCREAMING_SNAKE_CASE tags recently
Sam Mohr (Jan 09 2025 at 21:38):Though I'm only seeing a single word for these
Luke Boswell (Jan 09 2025 at 21:46):Where have you seen that?
Sam Mohr (Jan 09 2025 at 21:46):GET, POST, DELETE, etc.
Luke Boswell (Jan 09 2025 at 21:48):We had a conversation about those specifically, Richard wanted them UPPERCASE
Sam Mohr (Jan 09 2025 at 21:48):But what should we do if it's two words
Sam Mohr (Jan 09 2025 at 21:48):TWOWORDS or TWO_WORDS?
Sam Mohr (Jan 09 2025 at 21:49):We could allow either SCREAMING_SNAKE_CASE or PascalCase, but you can only have either underscores or lowercase letters
Luke Boswell (Jan 09 2025 at 21:52):I like SCREAMING_CASE for constants, so for tag unions without payloads it kind of feels ok
Luke Boswell (Jan 09 2025 at 21:53):Maybe tag unions with payloads are only PascalCase? (just spitballing here)
Luke Boswell (Jan 09 2025 at 21:54):I don't think we want to be too restrictive. Maybe just allow anything as long as it starts with an Uppercase ASCII letter?
Sam Mohr (Jan 09 2025 at 21:55):For context, I'm trying to write a utility that parses out relevant info for names in one O(n) pass, e.g.
Sam Mohr (Jan 09 2025 at 21:57):This will help with reporting non-snake_case names, in addition to other stuff
Sam Mohr (Jan 09 2025 at 21:58):We definitely want to allow running any code even if we don't like it
Sam Mohr (Jan 09 2025 at 21:59):But I think Roc being opinionated on style makes code more consistent in unfamiliar codebases, which is a really nice feature
Sam Mohr (Jan 09 2025 at 21:59):I don't think we should allow more than one underscore in a row, for example
Richard Feldman (Jan 09 2025 at 22:13):yeah I agree about disallowing (via warning) multiple underscores in a row
Sam Mohr (Jan 09 2025 at 22:13):Should we allow First_Second?
Sam Mohr (Jan 09 2025 at 22:14):I think no
Richard Feldman (Jan 09 2025 at 22:14):I think that's ok. I could imagine a scenario where you're trying to make a tag for each field in a record or something
Richard Feldman (Jan 09 2025 at 22:14):and there might be underscores in there, and you want them to match up
Sam Mohr (Jan 09 2025 at 22:15):fair
Anton (Jan 10 2025 at 09:29):We might consider moving as many tests into snapshots as possible at some point
I'm not a fan of that, I think it's difficult for newcomers to find the snapshot file for a specific test. It requires more effort to see the input for a test for experienced people too.
Sam Mohr (Jan 10 2025 at 09:38):Okay, makes sense. I think the thing I was thinking of was that we should make it easy to update tests with Roc changes, but that should happen if we make add warnings for invalid Roc
Last updated: Jul 06 2025 at 12:14 UTC