Stream: contributing

Topic: ✔ good first issue


view this post on Zulip Anton (Dec 01 2025 at 19:31):

Good first issue right here: https://github.com/roc-lang/roc/issues/8533

view this post on Zulip Richard Feldman (Dec 01 2025 at 19:46):

I already pushed a PR fixing this, sorry! :sweat_smile:

view this post on Zulip Richard Feldman (Dec 01 2025 at 19:47):

(also fwiw I don't think it turned out to be actually a good first issue - turned out we were still using a "quick & dirty" hack for getting pf out of these headers instead of using our actual parser)

view this post on Zulip Notification Bot (Dec 01 2025 at 19:48):

Anton has marked this topic as resolved.

view this post on Zulip Kilian Vounckx (Dec 01 2025 at 19:58):

Richard Feldman said:

(also fwiw I don't think it turned out to be actually a good first issue - turned out we were still using a "quick & dirty" hack for getting pf out of these headers instead of using our actual parser)

Are you using the parser now? Because I also noticed you have to use pf as the platform name.

(I'm partial to having the name be different for each use case, cli for basic-cli, web for basic-webserver, w4 for wasm4. Though I might be alone in this fight :sweat_smile:)

view this post on Zulip Luke Boswell (Dec 01 2025 at 20:10):

I'm pretty sure pf isn't special or anything, I also like web cli or using other names for the platform

view this post on Zulip Richard Feldman (Dec 01 2025 at 21:26):

it was special in the old logic, which looks like it was intended to be a placeholder - it was super brittle and basically a regex that looked for pf among other things, wasn't actually using the full parser :laughing:

view this post on Zulip Richard Feldman (Dec 01 2025 at 21:27):

I actually thought I'd like cli or web better, but after trying both I'm back on pf - I just like the "don't think about it, it came from the platform so use pf" aspect - e.g. the muscle memory of always writing pf.Http no matter what I'm building


Last updated: Dec 21 2025 at 12:15 UTC