Stream: contributing

Topic: ✔ List.getWrap


view this post on Zulip Kilian Vounckx (Dec 15 2023 at 19:29):

I'm going through the issues to find one I can do. I found this one about List.getWrap. Is it still wanted? If so, should there be equivalent replaceWrap, setWrap and updateWrap?

view this post on Zulip Brendan Hansknecht (Dec 15 2023 at 20:03):

I wonder if this is still wanted/needed, my gut feeling is no

view this post on Zulip Brendan Hansknecht (Dec 15 2023 at 20:03):

It was original wanted for the dictionary implementation IIRC

view this post on Zulip Brendan Hansknecht (Dec 15 2023 at 20:04):

But the dict implementation now uses unchecked builtins.

On top of that, the wrapped version has some big performance issues if it uses division. And due to needing to check for division by zero still returns an error cases, so it doesn't save the user from needing to check a result.

view this post on Zulip Brendan Hansknecht (Dec 15 2023 at 20:05):

I think it is easy enough for the end user to just get módulo length of the list.

view this post on Zulip Brendan Hansknecht (Dec 15 2023 at 20:05):

So my gut feeling is we probably don't want it at this point

view this post on Zulip Richard Feldman (Dec 15 2023 at 20:11):

yeah I don't think we need it after all!

view this post on Zulip Notification Bot (Dec 15 2023 at 21:12):

Kilian Vounckx has marked this topic as resolved.


Last updated: Jul 06 2025 at 12:14 UTC