Anton (Oct 18 2024 at 15:36): Anton (Oct 18 2024 at 15:36):If an expect fails with roc dev, we should return exit code 1 right? Currently it's 0
Richard Feldman (Oct 18 2024 at 15:50):hm, I'm actually not sure - I could see arguments either way :thinking:
Richard Feldman (Oct 18 2024 at 15:50):on the one hand I could see the exit code being something that's an important part of the semantic of the program we're running, so we shouldn't mess with it
Richard Feldman (Oct 18 2024 at 15:51):on the other hand, I can see wanting to be able to run a script which involves running the program in a way that returns a nonzero exit code if an expect fails
Anton (Oct 18 2024 at 15:54):Valid arguments, the main thing I have in mind is that failures should not go unnoticed
Anton (Oct 18 2024 at 15:56):I'd be worried about people accidentally using roc dev in CI and thinking everything succeeded
Brendan Hansknecht (Oct 18 2024 at 16:03):We should not pick
Brendan Hansknecht (Oct 18 2024 at 16:03):We should leave it to the platform to pick
Brendan Hansknecht (Oct 18 2024 at 16:03):We just haven't wired that through yet
Brendan Hansknecht (Oct 18 2024 at 16:03):Anyway, I am definitely in the boat that it shouldn't be zero
Last updated: Jun 16 2026 at 16:19 UTC