Agus Zubiaga (Aug 30 2024 at 23:43): Agus Zubiaga (Aug 30 2024 at 23:43):I'd like to suggest a small guideline on merging PRs.
Sometimes, PRs introduce significant changes that require coordination and announcements. Other times, the author might come up with more test ideas or discover issues after getting an approving review. So, I think it'd be best to let the author merge their own PR.
If the changes are crucial, however, and waiting would be problematic, a person with merge permissions should still be able to make the call.
In general, I think we shouldn't merge other people's PRs (that aren't urgent) only because they are open and approved. If the author is an active community member, and we'd like to get something shipped, I suggest we ping them on Zulip or leave them a comment on GiHub first.
Richard Feldman (Aug 30 2024 at 23:45):makes sense to me! :thumbs_up:
Agus Zubiaga (Aug 30 2024 at 23:56):I don’t want to encourage perfectly good PRs sitting open unnecessarily. We can use discretion. I think this applies especially to big PRs with recent activity.
Brendan Hansknecht (Aug 31 2024 at 02:02):This makes sense overall. Generally there is not a big rush. I guess if we are coordinating multiple big prs it might make sense to merge them all back to back to back for some reason (or more likely, in a specific order), but I'm sure that's quite rare. I tend to turn on automerge for my smaller PRs. That said, I also don't really mind when someone just merges one of my self contained PRs.
Anton (Aug 31 2024 at 09:56):I often mark mine with WIP or DO NOT MERGE in the title
Last updated: Jun 16 2026 at 16:19 UTC