Fábio Beirão (Jun 01 2023 at 15:34): Fábio Beirão (Jun 01 2023 at 15:34)://context: insert image of dog wearing scientist coat, in a lab, and subtitled "I have no idea what I am doing"
That is how I have been feeling for the past few hours (in & out with other distractions) for trying to get a pretty error message for https errors (related to issue 5487)
After a few tumbles and the rust compiler screaming (and laughing!) at me, I got my glimpse of success :grinning_face_with_smiling_eyes:
Before:
image.png
Now (very very early, now I need to pattern-match on the different errors that come out from the https module):
image.png
But seeing some progress give me that jolt of joy that I remember feeling with Elm in the early days and also with roc these days. Awesome stuff you guys have built here! :clap:
Fábio Beirão (Jun 01 2023 at 17:22):Related to the message above, this is the current output for a hardcoded Problem::UnsupportedEncoding("application/json")
image.png
(I notice there is no newline at the end of the message, but I don't think that issue is in scope for this PR)
I have a 🚧 Draft PR 5498 with the strategy that I would be following.
Is it possible to get some :eyes: earlier, before I start adding messages to the other 7 + 6 + whatever is behind fs_extra::error::Error + whatever is behind reqwest::Error messages? :sweat_smile: Thank you so much :smiling_face:
Fábio Beirão (Jun 02 2023 at 08:03):I didn't yet get some :eyes: on it, but that's okay, I'll carry on with the missing messages. Worse case scenario it doesn't get merged and that's ok :grinning_face_with_smiling_eyes:
Fábio Beirão (Jun 02 2023 at 11:59):@Richard Feldman good morning :wave:. In the latest comment of PR 5498 I added the messages (plain text + console printscreen) that I am bringing with the PR. Hopefully this is what you were looking for. Now I just need to find a way to also make them fit with what seems to be the cache downloading mechanism or something :sweat_smile: onwards and upwards.
Fábio Beirão (Jun 05 2023 at 13:53):I think PR 5498 can be merged, the tests passed, finally :grinning_face_with_smiling_eyes: :pray:
Richard Feldman (Jun 05 2023 at 14:17):awesome! I won't have time to review today, but if someone else can take a look at the code, I think the overall approach is sweet! :smiley:
Last updated: Jul 05 2025 at 12:14 UTC