Oskar Hahn (Apr 24 2022 at 09:18): Oskar Hahn (Apr 24 2022 at 09:18):Hi. I created my first PR. The tutorial is currently broken and this PR should fix this.
https://github.com/rtfeldman/roc/pull/2936
Please give me feedback, if I did something wrong
Joshua Dall'Acqua (Dec 19 2022 at 00:03):Hey, Just created my first draft: https://github.com/roc-lang/roc/pull/4789. Would someone be willing to take a quick look before I mark it ready for review? Just want to make sure I am not missing anything :)
Folkert de Vries (Dec 19 2022 at 00:05):shape of everything looks fine, it's too late here for me to check the logic. CI will hopefully just figure that out
Joshua Dall'Acqua (Dec 20 2022 at 15:32):I have some test failing on a PR: https://github.com/roc-lang/roc/pull/4789 (Nix Mac x86, windows build and zig, rust wasm...) the only changes I made were to roc standard list library. I am on Linux x86 and using the Nix env, tests pass locally for me and the Linux tests pass on CI. Is there anything special I need to do to get all architectures passing on CI?
Brendan Hansknecht (Dec 20 2022 at 16:14):Did you run all the mono changes with a release build?
Brendan Hansknecht (Dec 20 2022 at 16:15):Mono tests only work with release builds
Brendan Hansknecht (Dec 20 2022 at 16:15):So you may have changed a number of extra things
Brendan Hansknecht (Dec 20 2022 at 16:16):That is just a quick guess from my phone. Can take a deeper look later today
Anton (Dec 20 2022 at 16:17):Pulling in the up to date main branch in your current branch will take care of the error on windows.
Anton (Dec 20 2022 at 16:19):The one on nix-macos-x86-64 happens sometimes, nothing is wrong there. Pushing the merge commit when you pull in main should fix that as well.
Anton (Dec 20 2022 at 16:21):The failure for "test zig, rust, wasm" is real I think.
Note that this failing test:
cargo run --locked --release -- test crates/compiler/builtins/roc/Str.roc
is not included in the standard cargo test --release.
Joshua Dall'Acqua (Dec 20 2022 at 16:28):Thanks for the help! I will merge main then see what I can do about the "zig rust wasm" test.
Joshua Dall'Acqua (Dec 20 2022 at 19:34):Brendan Hansknecht said:
Did you run all the mono changes with a release build?
I ran the testing and formatting commands in the Contributing.md file. Should this make the correct mono changes or is there more I need to do?
Folkert de Vries (Dec 20 2022 at 19:43):yes that should all be correct
Folkert de Vries (Dec 20 2022 at 19:43):your changes move some indices around, but nothing about codegen should really be affected
Joshua Dall'Acqua (Dec 21 2022 at 16:03):So the error ended up being a roc expect failing. The panic that was coming through was actually the error formatter not being able to find the file where the error occurred. I was able to get the error message I needed by hard-coding the path (see screenshot). Is this a known problem or something I should make a ticket for? Screenshot-from-2022-12-21-10-55-17.png
Anton (Dec 21 2022 at 16:23):I've never seen it before. Yes, please make an issue for it :)
Last updated: Jul 05 2025 at 12:14 UTC