Kiryl Dziamura (Jan 28 2024 at 18:17): Kiryl Dziamura (Jan 28 2024 at 18:17):Modulo operation (42 % 0) crashes instead of panicking (divison by zero (42 / 0) works as expected)
Not sure if a ticket has already been created
Brendan Hansknecht (Jan 28 2024 at 18:20):would mean that the wasm dev backend is missing the check if it is in the web repl. If it is in the local repl, it also affects the native dev backend
Kiryl Dziamura (Jan 28 2024 at 18:27):Locally it's
» 42 % 0
42 : Int *
which is not expected as well I think
Brendan Hansknecht (Jan 28 2024 at 18:28):I guess that if what the CPU instruction does when you pass in zero.... Lol
Asher Mancinelli (Jan 29 2024 at 01:15):Is behavior always defined in roc? I would think there would be some constant folding pass that catches this before the ast leaves the frontend if so.
Richard Feldman (Jan 29 2024 at 01:50):this is just a bug - we didn't implement the check :big_smile:
Richard Feldman (Jan 29 2024 at 01:50):the only optimizations we do are related to tail-calls, mutation, and memory management
Richard Feldman (Jan 29 2024 at 01:51):we don't yet do any inlining, constant folding, etc. - those are all left to LLVM for the moment
Kiryl Dziamura (Jan 29 2024 at 10:31):Filed an issue. The same for 42 // 0 btw
https://github.com/roc-lang/roc/issues/6459
Kiryl Dziamura (Jan 29 2024 at 16:15):@Richard Feldman I saw you closed the ticket, but the fix was only for //, not for %.
Tho looking at the fix for divTrunc by Folkert, I think I can quickly replicate it for rem
So if you reopen the issue, please assign it to me, I've already started! :grinning_face_with_smiling_eyes:
Notification Bot (Jan 30 2024 at 16:54):Kiryl Dziamura has marked this topic as resolved.
Last updated: Jul 06 2025 at 12:14 UTC